feat: custom wallet URI scheme #578
Conversation
Signed-off-by: Ariel Gentile <[email protected]>
Signed-off-by: Ariel Gentile <[email protected]>
genaris
force-pushed
the
feat/custom-wallet-uri-scheme
branch
from
dcee226 to
37be6e0
Compare
There was a problem hiding this comment.
We've discussed making this configurable, hadn't gotten around to adding the config so this is exactly what we'd set up. Thanks! 😄
I'll note we use aries_proof-request after the URI scheme, but it doesn't seem to matter to the BC Wallet what that string is. So that could optionally be configurable I guess if other wallets may care about that or something.
Signed-off-by: Ariel Gentile <[email protected]>
genaris
force-pushed
the
feat/custom-wallet-uri-scheme
branch
from
d1adad7 to
a26e971
Compare
Thanks for the comment! Certainly, both BC Wallet and some other apps won't care about the host part of the deep link when using their own custom URI scheme. However, I think you are right and it's worth to make it more flexible from the beginning, so I did some small modifications to convert this environment variable into a complete prefix. |
A proposal to make wallet deep link URI scheme configurable, so it may not only be used with BC Wallet (bcwallet://) but also with any Aries-capable agent that implements the concept defined in Aries RFC 0268.
It basically consists on using
WALLET_DEEP_LINK_PREFIXenvironment variable on the controller to set the URI scheme and host used as a prefix. For example, 'didcomm://oob-invitation' for URLs such asdidcomm://oob-invitation?c_i={base64encoded msg}.It keeps the default
bcwallet://aries_proof-requestto make this straightforward for BCGov use case.I hope you like it as much as we had fun using this project 🎉